707: Detect instance expressions with double quotes #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- like other functions, argument value(s) (instance name) should be allowed to be wrapped in single or double quotes. Previously only singles quotes worked.
lognaturel
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
A quick form I used to complement the tests: https://docs.google.com/spreadsheets/d/13Ow7UXMt5wjMXawa8XrJcoxGhnvwk91xHovFS8K0IVI/edit#gid=0
A small change with a big impact!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #707
Like other functions, argument value(s) (instance name) should be allowed to be wrapped in single or double quotes. Previously only singles quotes worked.
Why is this the best possible solution? Were any other approaches considered?
Uses existing XML generation function. Not sure why there was an f-string used before, maybe some kind of conflict with something else that has since been resolved.
What are the regression risks?
It's more consistent with the rest of pyxform now, but maybe some users don't want XML escapes here. As shown in the updated tests, other characters that will be escaped now are
<>&.Does this change require updates to documentation? If so, please file an issue here and include the link below.
No
Before submitting this PR, please make sure you have:
testspython -m unittestand verified all tests passruff format pyxform testsandruff check pyxform teststo lint code