Standardized Avatar #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No avatar selected is 'blank.gif' in user_avatar. Use core.userinfo.avatar event to get avatar image URL (which is absolute.)
This program uses an array of specific user information rather than a user object, so core.userinfo.avatar listeners modified to also accept array.
Instead of $xoops->disableErrorReporting(), a program can call $xoops->logger()->quiet() and any loggers which generate output as part of the page will stop the output. In the case of debugbar, the error reporting will continue, but be redirected to the currently displayed debugbar through headers, not page body content.
Some queries not being captured, using doctrine's logging mechanism solves this. Converted debugbar logger to use this method, leveraging some built in support. Conversion of other loggers will follow. When conversion is complete, we can remove all logging triggers from XOOPS database classes.
You will need to run 'composer update' to get changes. Also resource updates in debugbar module, and some gitignore tweaks.
geekwright
added a commit
that referenced
this pull request
Oct 6, 2013
Standardized avatar, database logging cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avatars are now managed in a module, but were still tied directly to the user_avatar column in the user table, making replacing the avatars module unlikely. These changes standardize the way an avatar image url is obtained, how the 'blank.gif' no avatar specified indication is initialized and handled. Also, added an alternative to the avatars module, gravatars, which uses gravatar.com managed avatars.