Build the command map at compile time (fix #3298) #4240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- time performance of parseCommand function - declare commands array as constexpr
|
@scottschurr @nbougalis let me know if this looks okay. |
nbougalis
suggested changes
Jul 16, 2022
There was a problem hiding this comment.
Thank you for doing this, but I think that the inline comment is not necessary.
Instead, what I recommend, is that you change this commit to simply remove the FIXME comment and provide a description of the tests you performed in the commit (i.e. what you have as a comment) as part of the commit message.
Detailed description: The below data structure (commands) is profiled with four alternatives - - linear search on an array - binary search on a sorted array - using std::map data structure - using std::unordered_map data structure. Both linear search and std::unordered_map outperformed the other alternatives. Hence, I don't think it warrants a change. If the number of rpc-handler-commands increase in the future, then there might be a scope for improvement. Detailed comparison - XRPLF#3298 (comment)
|
Okay, I have done the suggested changes 👍 |
intelliot
approved these changes
Jul 25, 2022
intelliot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If merged, this commit will: