Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build the command map at compile time (fix #3298) #4240

Closed
wants to merge 2 commits into from
Closed

Build the command map at compile time (fix #3298) #4240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
577e45b
- Provide comparitive analysis of Data Structures
Jul 15, 2022
3c0cb6d
comparitive analysis of data structures for RPCCall - fixes #3298
Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/ripple/net/impl/RPCCall.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1227,10 +1227,7 @@ class RPCParser
int maxParams;
};

// FIXME: replace this with a function-static std::map and the lookup
// code with std::map::find when the problem with magic statics on
// Visual Studio is fixed.
static Command const commands[] = {
static constexpr Command commands[] = {
// Request-response methods
// - Returns an error, or the request.
// - To modify the method, provide a new method in the request.
Expand Down