Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] CIDR mismatch #1933

Closed
Loyalsoldier opened this issue Apr 11, 2023 · 2 comments
Closed

[bug] CIDR mismatch #1933

Loyalsoldier opened this issue Apr 11, 2023 · 2 comments

Comments

@Loyalsoldier
Copy link
Contributor

You guys should fix this old bug from V2Ray.

Reference: v2fly/v2ray-core#1155
Solution: v2fly/v2ray-core#1157

Note: https://github.com/inetaf/netaddr has been deprecated, use https://pkg.go.dev/go4.org/netipx instead.
@kdurov
Copy link

kdurov commented Apr 11, 2023

感谢帮开 issue。
我还想看看具体什么情况能 reproduce 后开的。

@cty123 cty123 mentioned this issue Aug 24, 2023
Merged
cty123 added a commit to cty123/Xray-core that referenced this issue Aug 26, 2023
@cty123
fix(app): fixed a bug in geoip matching with refactoring(XTLS#1933).
ed5f548 
* Refactor the IP address matching with netipx library
* Add a regression test for previous bug
@RPRX RPRX closed this as completed in b24a402 Aug 26, 2023
@RPRX
Copy link
Member

RPRX commented Aug 26, 2023

感谢反馈

arm64v8a pushed a commit to MatsuriDayo/Xray-core that referenced this issue Aug 27, 2023
@RPRX @arm64v8a
Dialer: Set TimeoutOnly for gctx and hctx
fa35868 
XTLS/Xray-core#2232 (comment)

Thank @cty123 for testing

Fixes XTLS/Xray-core#2232

BTW: Use `uConn.HandshakeContext(ctx)` in REALITY

fix(app/router): fixed a bug in geoip matching with refactoring (#2489)

* Refactor the IP address matching with netipx library
* Add a regression test for previous bug

Fixes XTLS/Xray-core#1933

---------

Co-authored-by: Loyalsoldier <10487845+Loyalsoldier@users.noreply.github.com>

fix(transport): correctly release UDS locker file (#2305)

* fix(transport): correctly release UDS locker file

* use callback function to do some jobs after create listener

Update transport/internet/reality/reality.go

Fixes XTLS/Xray-core#2491

Upgrade dependencies

Update workflows to use Go 1.21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kdurov @Loyalsoldier @RPRX