-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ refactor geoip match logic #1157
Conversation
sorry is it too frequently to introduce third-party dependencies recently? |
Any problem? |
The issue here is that a third party dependency has been introduced on a critical module. Router, unlike transport or protocol, is not interchangeable, so if something goes wrong, there is no easy way to avoid it. There are some issues with third party libraries referenced in a critical module:
|
Codecov Report
@@ Coverage Diff @@
## master #1157 +/- ##
==========================================
- Coverage 44.77% 44.76% -0.02%
==========================================
Files 485 485
Lines 29539 29466 -73
==========================================
- Hits 13226 13189 -37
+ Misses 14909 14878 -31
+ Partials 1404 1399 -5
Continue to review full report at Codecov.
|
cc @maskedeken