Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a “maybe you need to refresh your panel token” message #25

Open
jaycrossler opened this issue Jun 2, 2022 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@jaycrossler
Copy link

If an incorrect panel token is entered, a stream of errors are thrown:

2022-05-19 16:41:18.893962 INFO qolsys_panel: Connection closed by the panel, exiting to reset the connection
2022-05-19 16:41:18.903517 INFO qolsys_panel: Establishing connection to 192.168.1.232:12345
2022-05-19 16:41:19.203002 INFO qolsys_panel: Connection closed by the panel, exiting to reset the connection
2022-05-19 16:41:19.216177 INFO qolsys_panel: Establishing connection to 192.168.1.232:12345

A better error handling message would help. Also, some other messages still seemed to be passed without a valid token (sensors triggering, just with no attached info about each sensor) as described in https://community.home-assistant.io/t/qolsys-iq-panel-2-and-3rd-party-integration/231405/524 - suggest either also catching those errors, or finding a gentler way of handling them (as some people might not have the panel code and still want to get some sensor data).

@XaF XaF added the enhancement New feature or request label Jun 2, 2022
@XaF
Copy link
Owner

XaF commented Jun 3, 2022

Most probably that the disconnect/reconnect errors cannot be linked to that kind of issue (except with a counter, and even then, could simply be a network issue).

I'll take a look at the sensor info with unknown zone data though:

022-05-19 16:41:21.375891 ERROR qolsys_panel: Error calling callback for event: <QolsysEventZoneEventUpdate zone=<QolsysSensorMotion id=BA74A5 name=Living Room Motion group=awayinstantmotion status=Closed state=0 zone_id=8 zone_type=2 zone_physical_type=2 zone_alarm_type=3 partition_id=0> version=1>
Traceback (most recent call last):
  File "/config/appdaemon/apps/qolsysgw/mqtt/listener.py", line 47, in event_callback
    await self._callback(event)
  File "/config/appdaemon/apps/qolsysgw/gateway.py", line 196, in mqtt_event_callback
    self._state.zone_update(event.zone)
  File "/config/appdaemon/apps/qolsysgw/qolsys/state.py", line 48, in zone_update
    raise Exception(f'Zone not found for zone update: {sensor}, '\
Exception: Zone not found for zone update: <QolsysSensorMotion id=BA74A5 name=Living Room Motion group=awayinstantmotion status=Closed state=0 zone_id=8 zone_type=2 zone_physical_type=2 zone_alarm_type=3 partition_id=0>, we might not be sync-ed anymore

The we might not be sync-ed anymore message could read we might not be sync-ed anymore, or the panel token might not be valid for instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants