Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClaimValueToggle only first claim #111

Closed
risogolo opened this issue Apr 30, 2020 · 3 comments
Closed

ClaimValueToggle only first claim #111

risogolo opened this issue Apr 30, 2020 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@risogolo
Copy link

risogolo commented Apr 30, 2020

I think ClaimValueToggle only evaluates only first apperance of the claim of the same type.
For example I have claims collection on http context containing claim of type Role with value "Role1" an claim of type Role with value "Role2", I guess it searches only for the firstone, but I have an user assigned to multiple roles so I have multiple claims of type Role assigned in http context

@unaizorrilla unaizorrilla self-assigned this Apr 30, 2020
@unaizorrilla unaizorrilla added the bug Something isn't working label Apr 30, 2020
@unaizorrilla
Copy link
Collaborator

Hi @risogolo

Thanks for fill the issue! After some review, I agree that this is a bug and toggle will check all claim values from some type.

I will try to fix this on Esquio 2 (current version) and also manage on Esquio 3, we are working hard to release the new version on this month!

I try to fix the issue

@unaizorrilla
Copy link
Collaborator

Hi @risogolo

A new package with version 2.0.4 will be available on nuget and this will solve the issue. I created a simple test to cover this and all is working

public async Task be_active_when_claim_type_and_value_are_successfully_configured_and_user_have_many_claim_of_the_same_type()

Please close the issue if new package solve the issue!

@risogolo
Copy link
Author

Thank you very much for your quick reposne and for this nice library , I confirm that works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants