Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config stanza for RPC billing limits instead of just hardcoded values #316

Open
WietseWind opened this issue May 23, 2024 · 0 comments
Open
Assignees
Labels
feature Feature Request High High Priority Bug (should be fixed immediately for next release) ripple(d) sync Sync w/ RIpple(d)

Comments

@WietseWind
Copy link
Contributor

WietseWind commented May 23, 2024

This is a bit of a prio 1 (1.1 😇) For infra operations at scale, RPC resource billing limits are too low.

Which results in dropping connections, rate limits, etc. Which results to failover on a cluster level (so users won't really notice, but still a waste of resources, reconnecting, etc.)

Here are the limits:

https://github.com/xahau/xahaud/blob/HEAD/src/ripple/resource/impl/Tuning.h#L34-L35

Proposal

Allow these values to be configured with config stanza, overruling the defaults.

... Then to be PRred into @xrplf/rippled as well.

XRPLF/rippled#2628

@WietseWind WietseWind added feature Feature Request ripple(d) sync Sync w/ RIpple(d) High High Priority Bug (should be fixed immediately for next release) labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature Request High High Priority Bug (should be fixed immediately for next release) ripple(d) sync Sync w/ RIpple(d)
Projects
None yet
Development

No branches or pull requests

3 participants