Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Ultimate performance optimizations of simulations.py (cythonization, multi-processing, and/or num tools) #31

Closed
wants to merge 29 commits into from

Conversation

nariman87
Copy link
Contributor

@nariman87 nariman87 commented May 11, 2022

Related Github issues

Relates to FT-Stack#91.

@nariman87 nariman87 requested a review from ilan-tz as a code owner May 11, 2022 14:43
@nariman87 nariman87 self-assigned this May 11, 2022
@nariman87 nariman87 marked this pull request as draft May 11, 2022 14:43
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #31 (bfba37c) into main (d9c3c00) will decrease coverage by 0.09%.
The diff coverage is 95.08%.

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   96.32%   96.22%   -0.10%     
==========================================
  Files          35       35              
  Lines        2123     2148      +25     
==========================================
+ Hits         2045     2067      +22     
- Misses         78       81       +3     
Impacted Files Coverage Δ
flamingpy/__init__.py 100.00% <ø> (ø)
flamingpy/cv/ops.py 91.57% <ø> (ø)
flamingpy/examples/decoding.py 100.00% <ø> (ø)
flamingpy/simulations.py 93.54% <94.33%> (-2.11%) ⬇️
flamingpy/cv/macro_reduce.py 95.68% <100.00%> (+0.03%) ⬆️
flamingpy/decoders/unionfind/algos.py 99.27% <100.00%> (ø)
flamingpy/decoders/unionfind/uf_classes.py 99.07% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9c3c00...bfba37c. Read the comment docs.

@nariman87 nariman87 added the performance This issue or request relate to integration of compiled backends and/or parrallelization tools label May 17, 2022
@nariman87
Copy link
Contributor Author

nariman87 commented May 18, 2022

Some useful tasks we can do here are benchmarking and profiling the performance to see how different steps, especially state preps compared to decoder, contribute to overall runtime.

@nariman87 nariman87 changed the title Ultimate performance optimizations of simulations.py [Placeholder] Ultimate performance optimizations of simulations.py May 24, 2022
@nariman87 nariman87 changed the title [Placeholder] Ultimate performance optimizations of simulations.py [Discussion] Ultimate performance optimizations of simulations.py May 26, 2022
@nariman87 nariman87 changed the title [Discussion] Ultimate performance optimizations of simulations.py [Discussion] Ultimate performance optimizations of simulations.py (C++ backends, mpi4py, and/or numba) Jun 7, 2022
@nariman87 nariman87 changed the title [Discussion] Ultimate performance optimizations of simulations.py (C++ backends, mpi4py, and/or numba) [Discussion] Ultimate performance optimizations of simulations.py (cythonization, mpi4py, and/or numba) Jun 7, 2022
@nariman87 nariman87 changed the title [Discussion] Ultimate performance optimizations of simulations.py (cythonization, mpi4py, and/or numba) [Discussion] Ultimate performance optimizations of simulations.py (cythonization, multi-processing, and/or num tools) Jun 17, 2022
@nariman87
Copy link
Contributor Author

nariman87 commented Jun 21, 2022

Current tasks for this PR will be performed via FTSTACK#91 and relevant PRs. I close and re-open as needed.

@nariman87 nariman87 closed this Jun 21, 2022
soosub pushed a commit that referenced this pull request Jul 29, 2022
MWPM abstraction and speedups; visualization and example decoupling; updates to setup.py; README additions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance This issue or request relate to integration of compiled backends and/or parrallelization tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants