-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve macronode reduction function #49
Conversation
- Function now called reduce_macronode_graph - Function used to be massive, but now split up into 8 small functions
Add docstring, better exception message, default cause as the first if block
Codecov Report
@@ Coverage Diff @@
## main #49 +/- ##
==========================================
- Coverage 96.32% 96.30% -0.03%
==========================================
Files 35 35
Lines 2123 2137 +14
==========================================
+ Hits 2045 2058 +13
- Misses 78 79 +1
Continue to review full report at Codecov.
|
Fold macronode reduction functions into their own class
Also move splitter_symp and invert_permutation to cv.ops
f283e58
to
831117b
Compare
Context for changes
< Describe your changes. Make sure to include a summarized description of the changes and fixed issues in the format below consistent with
CHANGELOG.md
. You cannot place N/A here. >Example usage and tests
< Add some example usage and tests showing how to utilize new features and fixes; otherwise, mark N/A below. >
Performance results justifying changes
< If you have improved a feature you should support it with some benchmarking and scaling results, plots, etc.; otherwise, mark N/A below. >
Workflow actions and tests
< In most cases, we need a set of unit tests that automatically and comprehensively test for newly added features. Discuss existing CI tests that cover the changes or any updates to the workflow here; otherwise, mark N/A below. >
Expected benefits and drawbacks
< Summarize your justifications for the change and its benefits. Is there any drawback that exists today with the changes or may occur in the future? You cannot place N/A here. >
Expected benefits:
Possible drawbacks:
Related Github issues
< Explicitly, link any corresponding issue and update the status of the relevant GitHub issue here; otherwise, mark N/A below. >
Checklist and integration statements
black
,docformatter
andpylint
configurations.README.md
as needed.CHANGELOG.md
following the template. I recognize that the developers may revisitCHANGELOG.md
and the versioning, and create a Special Release including my changes.