add ci build workflow #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mandrenkov
reviewed
Aug 23, 2021
| cibw_before_all: yum install -y openblas-devel | ||
| cibw_environment: CBLAS_ROOT=/usr/include/openblas | ||
| - os: macos-latest | ||
| cibw_environment: MACOSX_DEPLOYMENT_TARGET=10.14 # Required for C++17 support |
There was a problem hiding this comment.
This will fail when macos-latest points to Big Sur, right? If so, should we specify macos-10.15 explicitly?
There was a problem hiding this comment.
@brownj85 out of curiosity, is it relatively easy to support macos arm as well? I'm just thinking about the new M1 chip
There was a problem hiding this comment.
@josh146, in general yes, though we'd need a self-hosted runner to do automated testing. However the wheels wouldn't be pip installable because numba (via thewalrus) does not support macos arm (see numba/llvmlite#693).
Co-authored-by: Mikhail Andrenkov <Mandrenkov@users.noreply.github.com>
Co-authored-by: Mikhail Andrenkov <Mandrenkov@users.noreply.github.com>
Co-authored-by: Mikhail Andrenkov <Mandrenkov@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Building wheels in CI will make releasing Jet on PyPI much easier. cibuildwheel makes packaging wheels for all the different combinations of platforms and python versions much easier.
Description of the Change:
Adds a workflow using cibuildwheel that builds and tests wheels for python versions 3.7, 3.8, and 3.9 on Linux-x86_64 macOS-x86_64. The wheels are uploaded as build artifacts.
The workflow is triggered on the creation of a release, since the job is pretty heavy. It can also be triggered manually (see https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow), though unfortunately this PR has to be merged first.
Benefits:
Uses best practices for building wheels. In future, it can be extended to automatically upload wheels to PyPI.
Possible Drawbacks:
Related GitHub Issues: