Add n-mode gaussian transformation gate in TFbackend #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can not pass the tests because it can not import the function from TW for now. |
josh146
reviewed
Oct 29, 2021
josh146
reviewed
Oct 29, 2021
josh146
reviewed
Oct 29, 2021
josh146
reviewed
Oct 29, 2021
thisac
reviewed
Oct 29, 2021
Co-authored-by: Theodor <theodor.isacsson@gmail.com>
ziofil
approved these changes
Nov 2, 2021
| idl = tf.eye(2 * m, dtype=dtype) | ||
| Rot = tf.cast(tf.math.sqrt(0.5), dtype=dtype) * tf.concat( | ||
| [tf.concat([idl, 1j * idl], 1), tf.concat([idl, -1j * idl], 1)], 0 | ||
| ) |
There was a problem hiding this comment.
I think the Rot matrix should be available in TW somewhere (@nquesada). Also, perhaps we can avoid creating a new one each time?
| ) | ||
| sigma = Rot @ choi_cov @ tf.transpose(tf.math.conj(Rot)) | ||
| zh = tf.zeros([2 * m, 2 * m], dtype=dtype) | ||
| X = tf.concat([tf.concat([zh, idl], 1), tf.concat([idl, zh], 1)], 0) |
There was a problem hiding this comment.
This too I believe is in TW
Mandrenkov
added a commit
that referenced
this pull request
Nov 3, 2021
Mandrenkov
added a commit
that referenced
this pull request
Nov 3, 2021
* Lift TF installation assumption from frontend tests * Update changelog * Refactor mock TensorFlow imports * Run black formatter * Remove isolated .backend artefact from merge * Use sf.LocalEngine() in frontend tests and gate TF version tests * Restore test coverage to incorrect TF version check * Restore TFBackend import to bottom of file * Fix TF imports in frontend tests following #599 * Remove release note about TF test fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the work to add an n-mode gaussian transformation gate (class Ggate) basing on TFbackend, with my supervisor @ziofil and with the help of @nquesada.
The main idea is to create the n-mode gaussian gate from its (S,d) parameters [Symplectic matrix and displacement vector] to its (C, mu, Sigma) parameters and then get the matrix of gate recursively.
[Warning:]
This gate has a special optimizer.
This gate haven't finished the decomposition part.