Rescale fock_tensor #107
Merged
Rescale fock_tensor #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh146
approved these changes
Dec 23, 2019
thewalrus/quantum.py
Outdated
| @@ -501,6 +501,9 @@ def state_vector(mu, cov, post_select=None, normalize=False, cutoff=5, hbar=2, c | |||
| relation :math:`[\x,\p]=i\hbar`. | |||
| check_purity (bool): if ``True``, the purity of the Gaussian state is checked | |||
| before calculating the state vector. | |||
| choi_r (float or None): Value of the two-mode squeezing parameter used in Choi-Jamiolkoski | |||
| trick in `fock_tensor`. This variable is only used when `state_vector` is called | |||
There was a problem hiding this comment.
Suggested change
| trick in `fock_tensor`. This variable is only used when `state_vector` is called | |
| trick in :func:`~.fock_tensor`. This keyword argument should only be used when ``state_vector`` is called |
thewalrus/quantum.py
Outdated
| @@ -501,6 +501,9 @@ def state_vector(mu, cov, post_select=None, normalize=False, cutoff=5, hbar=2, c | |||
| relation :math:`[\x,\p]=i\hbar`. | |||
| check_purity (bool): if ``True``, the purity of the Gaussian state is checked | |||
| before calculating the state vector. | |||
| choi_r (float or None): Value of the two-mode squeezing parameter used in Choi-Jamiolkoski | |||
| trick in `fock_tensor`. This variable is only used when `state_vector` is called | |||
| by `fock_tensor`. | |||
There was a problem hiding this comment.
Suggested change
| by `fock_tensor`. | |
| by :func:`~.fock_tensor`. |
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 97.73% 97.74% +<.01%
==========================================
Files 12 12
Lines 884 885 +1
==========================================
+ Hits 864 865 +1
Misses 20 20
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the numerical stability of the
fock_tensorfunction by rescaling the matrix whose batch hafnians are needed. That way one does not need to rescale the value of the matrix elements after they have been calculated. This is done by passing an extra argument tostate_vector.