Fix C++ unit tests

[trevor-vincent]

Context:

Normal distribution deviates are picked from N(0,1) to create random matrices in the unit tests. The unit tests were accidentally using N(1,0) instead which just creates matrices with only ones.

Description of the Change:

Change N(1,0) to N(0,1) everywhere in the unit tests and enforce symmetry of matrices in unit tests.
AllOneRpt unit tests only need matrices with only ones, so the random number generation was removed.

Benefits:

Tests now use random matrices

Possible Drawbacks:

Formatting of the code has changed slightly. Should I run this through clang-tidy?

Related GitHub Issues:

[josh146]

Thanks for catching this @trevor-vincent! We've actually been using astyle for formatting, but perhaps it should be better to start using clang-tidy instead.

[codecov]

Codecov Report

Merging #118 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   97.75%   97.75%           
=======================================
  Files          12       12           
  Lines         891      891           
=======================================
  Hits          871      871           
  Misses         20       20

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de39674...accb8e4. Read the comment docs.

[nquesada]

This is great. Thanks for fixing improving the tests @trevor-vincent . Any reason why we should change the formatting? Is one of them more "consistent" with PEPE8?

[trevor-vincent]

Thank you guys. No reason for the formatting change, It was accidental. I will run astyle through it, push the changes and squash the commits later whenever the pull request is ready.