Autonne-Takagi decomposition #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 939 955 +16
=========================================
+ Hits 939 955 +16
Continue to review full report at Codecov.
|
thisac
approved these changes
Mar 30, 2020
|
|
||
| Returns: | ||
| tuple[array, array]: (r, U), where r are the singular values, | ||
| and U is the Autonne-Takagi unitary, such that :math:`A = U \diag(r) U^T`. |
There was a problem hiding this comment.
What does the \diag(r) in :math:'A = U \diag(r) U^T' print? I don't think that's a regular latex command, or does it somehow work differently in Sphinx?
There was a problem hiding this comment.
Nothing really. Typically we just use a macro defined somewhere to replace \diag to \text{diag}.
josh146
reviewed
Mar 31, 2020
|
|
||
| Returns: | ||
| tuple[array, array]: (r, U), where r are the singular values, | ||
| and U is the Autonne-Takagi unitary, such that :math:`A = U \diag(r) U^T`. |
There was a problem hiding this comment.
A bit late, but there is a typo here, this line should be de-indented!
tuple[array, array]: (r, U), where r are the singular values,
and U is the Autonne-Takagi unitary, such that :math:`A = U \diag(r) U^T`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to perform the Autonne-Takagi decomposition of a complex-symmetric matrix.