Improved test #23
Merged
Improved test #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh146
reviewed
Jul 10, 2019
josh146
requested changes
Jul 10, 2019
josh146
reviewed
Jul 10, 2019
|
It looks like the tolerance might be too low on |
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
====================================
Coverage 95% 95%
====================================
Files 8 8
Lines 560 560
====================================
Hits 532 532
Misses 28 28Continue to review full report at Codecov.
|
josh146
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change:
Makes all the use np.allclose for comparisons. Also adds new test for the torontonian functions
Benefits:
More and better tests
Possible Drawbacks:
Related GitHub Issues: