-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not use __float128 on non-intel platforms #296
Conversation
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 1451 1458 +7
=========================================
+ Hits 1451 1458 +7
Continue to review full report at Codecov.
|
Hi @brownj85, thanks for your contribution! 🚀 |
@brownj85 @sduquemesa note that in the development version of the walrus we do not use C++ for permanents anymore. I think this PR can be closed and just wait til the next release. |
Closing this since the dependency on C++ has been removed in the latest release. |
Context:
Aliasing of type
__float128
was resulting in build failures on aarch64. This is because the GCCextension that provides this type is not available on aarch64.
Description of the Change:
Adds a compiler check in
permanent.hpp
to prevent aliasing__float128
if the platform is not i386 or AMD64. Other platforms will fall back to double precision.Benefits:
Build will succeed on aarch64.
Possible Drawbacks:
To keep the compiler check simple, it will exclude certain exotic architectures that do support
__float128
, such as PowerPC.Related GitHub Issues:
#290