Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markup extension formatting does work as expected when nested #34

Closed
MichaeIDietrich opened this issue Jul 20, 2016 · 1 comment
Closed
Assignees
Labels

Comments

@MichaeIDietrich
Copy link

Supposed you have two markup extensions, {Binding} and {LogicalAnd}.
In your Xaml Styler settings {Binding} is set to be kept on a single line.

If you format the given XAML, the result would be this:

<TextBox Text="Some Value"
         IsEnabled="{LogicalAnd {Binding IsWritable},
                                {Binding ElementName=CheckBox,
                                         Path=IsChecked}}" />

But the correct format would be:


<TextBox Text="Some Value"
         IsEnabled="{LogicalAnd {Binding IsWritable},
                                {Binding ElementName=CheckBox, Path=IsChecked}}" />

since {Binding} should be on a single line even if it is nested.

Currently the most outer markup extension defines the format for the whole attribute value.

This issue is fixed with: #33

@NicoVermeir NicoVermeir added this to the 2.3 milestone Aug 24, 2016
@NicoVermeir
Copy link
Contributor

thanks for the contribution!
I was checking out the PR and noticed that some unit tests are failing, could you have a look and update your PR?

thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants