Fixed formatting for nested markup extensions #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- MarkupExtensionFormatter is now invoked recursively if attributes contain nested markup extensions - elements with only one attribute are now correctly respect markup extension formatting
| @@ -80,7 +87,7 @@ private IEnumerable<string> Format(Value value) | |||
|
|
|||
| if (type == typeof(MarkupExtension)) | |||
| { | |||
| return this.Format((MarkupExtension)value); | |||
| return this.markupExtensionFormatter.Format((MarkupExtension)value); | |||
There was a problem hiding this comment.
recursively call markup extension formatting
|
Thank you for your contribution! Unfortunately, there are 16 failing unit tests with this PR. Please take a look at the failing tests, make any appropriate changes, and update the PR when all tests are passing. |
|
Fix implemented in #72 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contain nested markup extensions
extension formatting