Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code: Initialize worker count to 0 #1021

Merged
merged 1 commit into from
Feb 11, 2023
Merged

code: Initialize worker count to 0 #1021

merged 1 commit into from
Feb 11, 2023

Conversation

Xaymar
Copy link
Contributor

@Xaymar Xaymar commented Feb 11, 2023

Explain the Pull Request

Many platforms (and/or kernels) don't zero memory before it is acquired, resulting in uninitialized memory being used to store critical content. This made the threadpool assume it had an infinite number of threads to work with, despite actually having spawned none.

Fixes #1017

Completion Checklist

  • This has been tested on the following platforms:
    • MacOS 10.15
    • MacOS 11
    • MacOS 12
    • Ubuntu 20.04
    • Ubuntu 22.04
    • Windows 10
    • Windows 11
  • The copyright headers and license files have been updated.
  • I will maintain this for the forseeable future, and have added myself to CODEOWNERS.

Many platforms (and/or kernels) don't zero memory before it is acquired, resulting in uninitialized memory being used to store critical content. This made the threadpool assume it had an infinite number of threads to work with, despite actually having spawned none.

Fixes #1017
@Xaymar Xaymar merged commit ed61664 into root Feb 11, 2023
@Xaymar Xaymar deleted the patch/worker-count branch February 11, 2023 19:46
@Xaymar Xaymar added this to the 0.12 milestone Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StreamFX 0.12 causes OBS 29.0.0 to hang on exit on Linux
2 participants