Speed up builds on CI #1029
Merged
Speed up builds on CI #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xaymar
force-pushed
the
patch/ci-speedup
branch
from
cf33a50
to
4c0ccec
Compare
Turns out to be very pointless, and usually doubles or triples the overall build time with no actual gain.
Xaymar
force-pushed
the
patch/ci-speedup
branch
from
4c0ccec
to
c66aa83
Compare
There's no need to split by configuration type on proper generators, which slightly speeds up the build. Downside is that we can't get builds for both Debug and RelWithDebInfo - though we only need the latter anyway.
Xaymar
force-pushed
the
patch/ci-speedup
branch
from
c66aa83
to
69c5977
Compare
A full clean build is only required for releases, so opting for iterative builds will speed up CI builds significantly. As we can re-use caches from across branches, opting for the first matching key, this means that any branch should re-use the closest match from the main branch. Downside is that this may break if there is a change to the CMakeLists.txt file, since the project configuration is now different. Might be fixable, but that's not the aim of these changes.
Xaymar
force-pushed
the
patch/ci-speedup
branch
from
69c5977
to
05896b8
Compare
|
Seems like this is the limit without splitting the builds into two different invocations. Around 10 minutes is a good time for builds, though ideally I wish I could drop it to just 2 to 3 minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the Pull Request
Attempt to improve the speed of builds on CI, given than they started to end up running for 30 minutes or more.
Completion Checklist
CODEOWNERS.