Add support for OBS Browser Source Qt Widgets #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xaymar
force-pushed
the
feature/obs-browser-widget
branch
from
73e15c3
to
7db8266
Compare
|
No idea what AppleClang wants from me here. MSVC, GCC and Clang appear happy with it, but AppleClang decides to be special yet again. |
Xaymar
force-pushed
the
feature/obs-browser-widget
branch
6 times, most recently
from
151bf77
to
89a0512
Compare
Provides us with an easy and clean way to use Browser Sources as a Qt enabled widget.
Fixes some strange compiler issues.
…land The obs-browser module does not work well on Wayland, so removing it there appears to be the best option for now.
When a QCefWidget is alone and all by itself, no layout updates are performed on the "window". This causes a problem where it just stays in place, instead of moving with the rest of the elements. The fix to this appears to be to just add a different Qt widget into the layout. Looks stupid, is stupid, but works anyway. Qt is weird.
Qt's CMake integration does not pass the C++ standard to AutoMoc, resulting in weird parsing issues (see https://bugreports.qt.io/browse/QTBUG-73263).
MacOS complains that QCefWidget is an undefined type, while all other compilers are fine.
Xaymar
force-pushed
the
feature/obs-browser-widget
branch
from
89a0512
to
29b2baa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the Pull Request
Adds support for adding OBS Browser Source Qt Widgets for future features, like embedded documentation, properly updating credits, and similar. The possibilities of a working browser integration are endless - might even be able to use it for better UI controls somehow.
Completion Checklist
CODEOWNERS.