ffmpeg/tools: Set correct information when encoding #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the previous logic and makes it compatible with the new additions in 26.x, such as sRGB. This was previously broken as the focus was on existing features which could be tested without requiring a compiler to be installed. Incorrect understanding of how sRGB works with RGB and YCC/YUV formats also caused sRGB to be treated as RGB when I444 was selected. This should also now be fixed, hopefully permanently. Fixes #331
Xaymar
added
testing-required
|
Seems to work fine from testing. Fixes the weird sRGB color issue. |
Xaymar
added a commit
that referenced
this pull request
Nov 1, 2020
* #366 Fix an on-launch crash caused by missing initializers. * #363 Fix a weird angle definition in 'hexagonize.effect'. * #355 Fix incorrect or bad values being logged in FFmpeg Encoders. * #353 Fix weird color conversion issues. * #347 Fix hidden modal windows preventing 'Hide to Tray' from working. * #345 Fix Windows Installer being 32-bit instead of 64-bit
Xaymar
removed
the
bug
Xaymar
added a commit
that referenced
this pull request
Mar 28, 2023
* #366 Fix an on-launch crash caused by missing initializers. * #363 Fix a weird angle definition in 'hexagonize.effect'. * #355 Fix incorrect or bad values being logged in FFmpeg Encoders. * #353 Fix weird color conversion issues. * #347 Fix hidden modal windows preventing 'Hide to Tray' from working. * #345 Fix Windows Installer being 32-bit instead of 64-bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves the previous logic and makes it compatible with the new additions in 26.x, such as sRGB. This was previously broken as the focus was on existing features which could be tested without requiring a compiler to be installed.
Incorrect understanding of how sRGB works with RGB and YCC/YUV formats also caused sRGB to be treated as RGB when I444 was selected. This should also now be fixed, hopefully permanently.
Testing Required
Color Formats
Color Spaces
Related Issues