Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoder-ffmpeg.cpp: Use correct format specifier #355

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

danimo
Copy link
Contributor

@danimo danimo commented Oct 8, 2020

Description

Related Issues

@danimo danimo requested a review from Xaymar as a code owner October 8, 2020 15:01
@Xaymar
Copy link
Owner

Xaymar commented Oct 8, 2020

codec->id is supposed to be codec->name. Classic Copy&Paste error.

@danimo
Copy link
Contributor Author

danimo commented Oct 9, 2020

Fair enough, updated :)

@Xaymar
Copy link
Owner

Xaymar commented Oct 9, 2020

I made the same error also on line 1154: https://github.com/Xaymar/obs-StreamFX/blob/master/source/encoders/encoder-ffmpeg.cpp#L1154 - I think that one is used for Ubuntu 18.04

@Xaymar Xaymar merged commit bb3dcf7 into Xaymar:master Oct 9, 2020
Xaymar added a commit that referenced this pull request Nov 1, 2020
* #366 Fix an on-launch crash caused by missing initializers.
* #363 Fix a weird angle definition in 'hexagonize.effect'.
* #355 Fix incorrect or bad values being logged in FFmpeg Encoders.
* #353 Fix weird color conversion issues.
* #347 Fix hidden modal windows preventing 'Hide to Tray' from working.
* #345 Fix Windows Installer being 32-bit instead of 64-bit
Xaymar added a commit that referenced this pull request Mar 28, 2023
* #366 Fix an on-launch crash caused by missing initializers.
* #363 Fix a weird angle definition in 'hexagonize.effect'.
* #355 Fix incorrect or bad values being logged in FFmpeg Encoders.
* #353 Fix weird color conversion issues.
* #347 Fix hidden modal windows preventing 'Hide to Tray' from working.
* #345 Fix Windows Installer being 32-bit instead of 64-bit
@Xaymar Xaymar added this to the FFmpeg Encoders (Component) milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants