encoder/ffmpeg: Add split framerate with integer fractions #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xaymar
commented
Sep 14, 2022
Xaymar
force-pushed
the
feature/846-framerate-adjustment-for-encoders
branch
3 times, most recently
from
ad10fe1
to
e2a9782
Compare
It seems to be possible to encode with a different framerate than what libOBS is configured for. While technically any framerate appears to be possible, it is currently limited to integer fractions only in order to make the implementation much easier. Integer fractions only require skipping N frames and multiplying the denominator by N, where N is the configured integer. For sanity reasons, the limit of N is currently 10. This allows power users to split their streaming and recording framerates with relative ease, and opt for things such as: - 30 FPS (1/4) streaming with 120 FPS (1/1) recording. - 30 FPS (1/10) streaming with 300 FPS (1/1) recording. - 30 FPS (1/10) streaming with 100 FPS (1/3) recording. - and so on. While some of these combinations are just stupid, they are now available to power users.
Xaymar
force-pushed
the
feature/846-framerate-adjustment-for-encoders
branch
from
e2a9782
to
3783d06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the Pull Request
It seems to be possible to encode with a different framerate than what libOBS is configured for. While technically any framerate appears to be possible, it is currently limited to integer fractions only in order to make the implementation much easier. Integer fractions only require skipping N frames and multiplying the denominator by N, where N is the configured integer. For sanity reasons, the limit of N is currently 10.
This allows power users to split their streaming and recording framerates with relative ease, and opt for things such as:
While some of these combinations are just stupid, they are now available to power users.
Completion Checklist
CODEOWNERS.