Skip to content
This repository has been archived by the owner on Aug 21, 2022. It is now read-only.

django-api | sh: 1: /pre-start.sh: not found infinite loop when building with docker-compose #80

Closed
milan-tom opened this issue Jan 25, 2021 · 4 comments · Fixed by #76 or #81
Closed
Assignees
Labels
bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request

Comments

@milan-tom
Copy link
Collaborator

Describe the bug
During building using docker-compose up --build, an infinte loop is caused with the following message being outputted repeatedly:

django-api  | docker-compose-wait - Everything's fine, the application can now start!
django-api  | --------------------------------------------------------
django-api  | sh: 1: /pre-start.sh: not found

To Reproduce
Steps to reproduce the behavior:

  1. Clone the repository
  2. Add a .env file in the cloned repository.
  3. Run docker-compose up --build
  4. See error

Expected behavior
Build completed successfully

Screenshots
An infinite loop unfolds:
image

Desktop:

  • OS: Windows 10
@milan-tom
Copy link
Collaborator Author

milan-tom commented Jan 25, 2021

This is a Windows-specific issue.

Fix:
Convert the line endings of pre-start.sh from Windows line endings to Unix line endings (can easily be done in Notepad++ by going to Edit > EOL Conversion > Unix (LF))

@codecakes codecakes linked a pull request Jan 26, 2021 that will close this issue
@codecakes codecakes self-assigned this Jan 26, 2021
@codecakes codecakes added bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request labels Jan 26, 2021
@milan-tom
Copy link
Collaborator Author

Could we perhaps just convert the line endings to Unix line endings for pre-start.sh by default in the repository @codecakes? Would that cause any further issues?

@milan-tom
Copy link
Collaborator Author

milan-tom commented Jan 26, 2021

Could we perhaps just convert the line endings to Unix line endings for pre-start.sh by default in the repository @codecakes? Would that cause any further issues?

@codecakes I see that this has been done manually in #76 (specifically in this section).

@premalrupnur
Copy link
Collaborator

Thanks for this issue @milan-tom I too , am facing same issue this would help

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
3 participants