Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rocksdb: compression types are configurable for each level separately #243

Merged
merged 3 commits into from
Jan 7, 2019

Conversation

acelyc111
Copy link
Member

@acelyc111 acelyc111 commented Dec 24, 2018

issue: #236
暂不支持表级配置
暂不支持动态修改

@acelyc111 acelyc111 force-pushed the compress_option_simple branch 2 times, most recently from 1ca443e to dcd6bee Compare December 25, 2018 06:21
neverchanje
neverchanje previously approved these changes Dec 27, 2018
@qinzuoyan
Copy link
Contributor

是否能支持下动态修改?可以先只支持统一的哪种

@acelyc111
Copy link
Member Author

是否能支持下动态修改?可以先只支持统一的哪种

统一的方式有个问题是跟我们现在的配置为一种压缩方式也有冲突,他会将所有层的压缩方式都修改,而不是level 2及以上

@acelyc111
Copy link
Member Author

是否能支持下动态修改?可以先只支持统一的哪种

统一的方式有个问题是跟我们现在的配置为一种压缩方式也有冲突,他会将所有层的压缩方式都修改,而不是level 2及以上

后面我看下能否改下rocksdb源码,让它支持多层次的压缩方式动态修改

@qinzuoyan qinzuoyan merged commit 51ff5d3 into apache:master Jan 7, 2019
neverchanje pushed a commit to neverchanje/pegasus that referenced this pull request Jul 13, 2019
…apache#243)

Former-commit-id: ef52c90329b14c4cdbbf8c9137a80a82eb129071 [formerly 51ff5d3]
Former-commit-id: 413e84169a75736252fafc73829d891aedea9edd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants