-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rocksdb: compression types are configurable for each level separately #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
force-pushed
the
compress_option_simple
branch
2 times, most recently
from
December 25, 2018 06:21
1ca443e
to
dcd6bee
Compare
neverchanje
reviewed
Dec 25, 2018
neverchanje
reviewed
Dec 26, 2018
neverchanje
reviewed
Dec 26, 2018
neverchanje
reviewed
Dec 26, 2018
neverchanje
reviewed
Dec 26, 2018
neverchanje
reviewed
Dec 26, 2018
neverchanje
reviewed
Dec 26, 2018
neverchanje
reviewed
Dec 26, 2018
neverchanje
reviewed
Dec 26, 2018
neverchanje
previously approved these changes
Dec 27, 2018
是否能支持下动态修改?可以先只支持统一的哪种 |
acelyc111
force-pushed
the
compress_option_simple
branch
from
January 3, 2019 03:10
22472a1
to
7844590
Compare
统一的方式有个问题是跟我们现在的配置为一种压缩方式也有冲突,他会将所有层的压缩方式都修改,而不是level 2及以上 |
后面我看下能否改下rocksdb源码,让它支持多层次的压缩方式动态修改 |
qinzuoyan
approved these changes
Jan 7, 2019
hycdong
approved these changes
Jan 7, 2019
qinzuoyan
pushed a commit
that referenced
this pull request
Feb 27, 2019
neverchanje
pushed a commit
to neverchanje/pegasus
that referenced
this pull request
Jul 13, 2019
…apache#243) Former-commit-id: ef52c90329b14c4cdbbf8c9137a80a82eb129071 [formerly 51ff5d3] Former-commit-id: 413e84169a75736252fafc73829d891aedea9edd
acelyc111
pushed a commit
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #236
暂不支持表级配置
暂不支持动态修改