scripts: improve falcon screen #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vagetablechicken
previously approved these changes
Jan 29, 2019
hycdong
reviewed
Jan 29, 2019
scripts/falcon_screen.json
Outdated
| ], | ||
| "graph_type": "a", | ||
| "method": "", | ||
| "timespan": 86400 | ||
| }, | ||
| { | ||
| "title": "各节点内存用量（单位：MB）", | ||
| "title": "P99 Prepare 客户端延迟（单位：纳秒）", |
There was a problem hiding this comment.
这个prepare客户端延迟，能不能换个名字？之前有业务问过，还以为是客户端监控
There was a problem hiding this comment.
那就叫发送端好了，不过本来 rdsn 就是叫 PREPARE.client
There was a problem hiding this comment.
嗯，counter这么说没问题，就是title上换掉客户端这几个字比较好，消除一下误解
neverchanje
approved these changes
Jan 29, 2019
hycdong
approved these changes
Jan 29, 2019
mentoswang
added a commit
to mentoswang/pegasus
that referenced
this pull request
Jan 30, 2019
scripts: improve falcon screen (apache#270)
mentoswang
added a commit
to mentoswang/pegasus
that referenced
this pull request
Feb 2, 2019
scripts: improve falcon screen (apache#270)
qinzuoyan
added a commit
that referenced
this pull request
Feb 27, 2019
neverchanje
pushed a commit
to neverchanje/pegasus
that referenced
this pull request
Jul 13, 2019
Former-commit-id: a4d0c72778462b9a7bf27d76c15298092d64104b [formerly ebbef4b] Former-commit-id: 3661736b6757f354f99bb79e68a188e794e30574
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include: