Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

feat: add http interface to get perf counter info #349

Merged
merged 8 commits into from
Dec 10, 2019
Merged

feat: add http interface to get perf counter info #349

merged 8 commits into from
Dec 10, 2019

Conversation

levy5307
Copy link
Contributor

@levy5307 levy5307 commented Dec 5, 2019 •
edited
Loading

Add a http interface to get perf counter info by the name of this perf counter.

request url:

http://127.0.0.1:34803/perfCounter?name=replica*eon.replica*table.level.RPC_RRDB_RRDB_PUT.latency(ns)@temp

response:

{"name":"replica*eon.replica*table.level.RPC_RRDB_RRDB_PUT.latency(ns)@temp","p99":"0.00","p999":"0.00","type":"PERCENTILE","description":"table.level.RPC_RRDB_RRDB_PUT.latency(ns)@temp"}

neverchanje
neverchanje reviewed Dec 5, 2019
View reviewed changes
Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

跟以前一样，PR description 要把接口的输出和 url 写出来。

src/core/perf_counter/perf_counters.cpp Outdated Show resolved Hide resolved
src/core/perf_counter/perf_counters.cpp Outdated Show resolved Hide resolved
src/core/perf_counter/perf_counters.cpp Outdated Show resolved Hide resolved
src/dist/http/perf_counter_http_service.h Outdated Show resolved Hide resolved
include/dsn/perf_counter/perf_counters.h Show resolved Hide resolved
src/dist/http/test/perf_counter_http_service_test.cpp Outdated Show resolved Hide resolved
src/dist/http/test/perf_counter_http_service_test.cpp Outdated Show resolved Hide resolved
@weekly-digest weekly-digest bot mentioned this pull request Dec 8, 2019
Closed
acelyc111
acelyc111 previously approved these changes Dec 9, 2019
View reviewed changes
neverchanje
neverchanje reviewed Dec 9, 2019
View reviewed changes
src/core/perf_counter/perf_counters.cpp Outdated Show resolved Hide resolved
src/dist/http/perf_counter_http_service.cpp Outdated Show resolved Hide resolved
src/dist/http/perf_counter_http_service.cpp Outdated Show resolved Hide resolved
@neverchanje
Copy link
Contributor

改了实现，单测没有改，PR description 也要改

@neverchanje neverchanje added the component/http HTTP/RESTful support label Dec 10, 2019
@neverchanje neverchanje merged commit daff2f9 into XiaoMi:master Dec 10, 2019
@weekly-digest weekly-digest bot mentioned this pull request Dec 15, 2019
Closed
acelyc111 pushed a commit that referenced this pull request Dec 31, 2019
@acelyc111
feat: add http interface to get perf counter info (#349)
0791461
@levy5307 levy5307 deleted the get-perf-counter branch May 26, 2020 06:02
This was referenced Jun 21, 2023
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@neverchanje neverchanje neverchanje approved these changes

@acelyc111 acelyc111 acelyc111 approved these changes

Assignees
No one assigned
Labels
1.12.2 component/http HTTP/RESTful support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@levy5307 @neverchanje @acelyc111