99 stream put uses inconsistent stream #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Hotfix issue with storing aligned buffer * Add missing include Co-authored-by: Tristan Laan <tristan.laan@gmail.com>
|
Every test seems to work and looks good to have a zero-based stream ID range for the API now. But couldn't this lead to problems when using the stream IDs in user kernels? For example in this test. I changed the send/recv into a |
|
Works now! Maybe we could also add the change of the loopback test to this PR, so we also have a test that proofs that the stream IDs work as expected? |
Mellich
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.