Fixing XRT compilation Issue on Ubuntu 23.10 (issue #7806)

[haghilin]

Problem solved by the commit:
There was compilation issues on Ubuntu 23.10 which was reported in issue #7806.

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
issue #7806

How problem was solved, alternative solutions (if any) and why they were rejected
Risks (if any) associated the changes in the commit
What has been tested and how, request additional testing if necessary

[keryell]

Just curious, why has it been closed?
I was so happy you solved my issue! :-)

[haghilin]

Hi Keryell,

Yeah, sorry by mistake I added 5 files without change to the commit so was trying to remove them from the PR. Will create the PR again shortly. :)

Thanks

[keryell]

You can just reopen the PR and just force-push again onto the same branch instead.

[haghilin]

Thanks Keryell for the help. I reverted the commit. It is now available for review.

[keryell]

Would it be possible to fix the root cause instead of make the compiler blind?

[stsoe]

Would it be possible to fix the root cause instead of make the compiler blind?

The warning isn't applicable here. A base class (B) has virtual methods (overloaded) foo() and foo(int) and some derived classes (D) redefine only a subset of these (say foo(int), so D->foo() won't work, but B->foo(10) does and the objects are used only through B. The warning is too aggressive IMO.

[gbuildx]

Build failed :(

[stsoe]

Thank you. Let's not disable the warning in header files, targeted few .cpp is okay. Else pragma push/pop.

[stsoe]

Not in header file, that disables for all compilation units that end up including this file.

[stsoe]

Ditto.

[stsoe]

Ditto

[keryell]

Thanks. With your branch I can compile but I hit later this issue:

Run CPack packaging tool...
CPack: Create package using DEB
CPack: Install projects
CPack: - Run preinstall target for: XRT
CPack: - Install project: XRT []
CPack: -   Install component: aws
CPack: -   Install component: azure
CPack: -   Install component: container
CPack: -   Install component: xbflash
CPack: -   Install component: xbflash2
CPack: -   Install component: xrt
CPack: Create package
CPackDeb: - Generating dependency list
CPackDeb: - Generating dependency list
CPackDeb: - Generating dependency list
CPackDeb: - Generating dependency list
CPackDeb: - Generating dependency list
CPackDeb: - Generating dependency list
CMake Error at /usr/share/cmake-3.27/Modules/Internal/CPack/CPackDeb.cmake:348 (message):
  CPackDeb: dpkg-shlibdeps: 'dpkg-shlibdeps: error: no dependency information
  found for opt/xilinx/xrt/lib/libxdp_core.so.2 (used by
  ./opt/xilinx/xrt/lib/xrt/module/libxdp_aie_trace_plugin.so)

  Hint: check if the library actually comes from a package.

  ';

  executed command: '/usr/bin/dpkg-shlibdeps -O
[...]

[haghilin]

This PR cannot be built due to long branch name. I created another PR #7841.
Thanks.