-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently not grabbing 1080p versions of shows and not showing Resolution correctly #86
Comments
I have the same problem I'm tinkering with the code, I may have a temporary solution |
It seems that there was changes on the xml response Previously, the xml would contain: <metadata>
<width>848</width>
<height>480</height>
<duration>1234.56</duration>
</metadata> But now it looks like this: <metadata>
<width></width>
<height></height>
<duration>1234.56</duration>
</metadata> That explains why the resolution is "x", the width and the height is empty |
@Nicnl So it is from Crunchyroll side. |
Along with that, it seems that there's some issues with those requests: anime-dl/anime_dl/sites/crunchyroll.py Lines 175 to 188 in 1766c1a
The parameter However, when I try to print the content of the anime-dl/anime_dl/sites/crunchyroll.py Line 249 in 1766c1a
It seems to contain all the resolutions:
|
Ok I made a pull request "It works on my end" I'll try to pack the .exe files for those who want |
If you can, that would be great and I can test it quickly using my script that pulls a bunch of shows. |
Here is a packed version
The fix is really disgusting though |
I wish these changes for better. |
Not working on my end with your packaged EXE, it's also 9708 KB vs 8418 KB of the previous version. I get the following error printed in the console: And this is my Error.log:
And this is my PowerScript logfile form my script I run for a bunch of shows:
|
Ooooh shit, I know |
Ok, I repacked it with the subtitles fix
|
Let me know if it's fixed |
Still not working correctly. Console Output:
Error Log:
|
Let me try it on a previous episode that I know has a 1080p video |
Okay, so it errors on a different step on the previous episode that I know has 1080p video download from alst week, and the current Web Player has a 1080p version. Console Output:
Error.log
|
It was not showing 1080p quality, but now it works:
|
:[ Sorry @axipher, I have no idea what's happening... I was searching and trying things to reproduce your issue without any luck And now that it works with Abu3safeer, I'm completely lost |
@Abu3safeer what show/episode was the one you ahve that works? I can try that on my end. Alternatively, can you try episode 22 of "That Time I Got Reincarnated As A Slime":
This is the full command I'm running:
|
I removed my entire local copy, redownloaded the dependencies, reapplied the patch and tried making a "cleaner" build Sorry for making you go though all this... |
@Nicnl Still same error, tried on a completely different show. If I remove the "-r 1080p" it oddly enough tries to pull 720p version on the second pass Console Command and log:
Error Log:
|
If you omit the Line 28 in 1766c1a
So, that's not really an odd behaviour What's odd is that, for some reason, the 1080p video is missing from the downloaded I would just advise you to edit the error logs you pasted
Those URLs contains private tokens Sorry, I permitted myself to download two of them, notably the slime and sword art online After stripping them of any important data, here what they looks like This one is the slime I think
There's only: 240p, 360p and 480p And this one the SAO
Again, there's only 240p, 360p and 480p I have no idea why you don't have a better video quality, maybe crunchyroll treats users differently depending on the country? |
Can confirm. |
@Nicnl Thanks for the tip on the private keys. Also normally I do get 1080p of everything in Canada. I wonder if Crunchyroll is just making some weird changes to stuff. Not sure what else I can provide you to help out here. |
Yeah, now that I think of it And... uh... it doesn't check if you're actually connected or not So if you enter wrong credentials, it will show login successful BUT you won't be able to download 1080p shows or get the exclusive episode of the week So, uh, @axipher, maybe you could triple check your account status and credentials? |
@basuritashka This is an experimental patch for the 1080p download resolution issue
If you could try it out and tell if it works, it'd be great! |
@Nicnl I am able stream on my browser though. And I get the resolution selection options as well. |
Yes, but well In the existing anime-dl, there's a big flaw concerning how the authentication is handled Basically, the authentication is NOT checked I've tried to fix this on a fork Could you try this version?
What changes in this version:
|
Same here, this is weird:
|
@Nicnl Tried the linked exe. Still same error Edit: |
|
Wait guys, there's something wrong |
How are you guys extracting the resolutions info from the m3u8 links? |
@Abu3safeer lemme check |
ohho ho yes.. it worked! |
Holy cow, I've linked the wrong exe |
@Nicnl No problems, just link the correct one, and if you could remove the old one so if anyone tried to download the old one it will redirect him to the new one. |
Oh thanks @Abu3safeer and @Nicnl |
Ok, this time I hope it'll work... |
@Nicnl can't actually talk against you. Cuz you are making this stuff workable. Thanks man. |
@Nicnl Actually I am the one who should be thankful for you, you are keeping this project alive, I really wish that I know python to help you. This application could be more powerful that what it is. I have even created a GUI for it using C# here: |
@Nicnl Thanks. The new exe works. Didn't need to add the fr/ar in url either. |
It is working like a charm now, even without language written. |
THERE WE GO Please note that there's still an ongoing issue I have to fix It turns out that axipher noticed that some animes have very uncommon resolutions
And right now adding |
You might do groups: So the application will get all resolutions, and put them in groups, so even if the resolution is not the exact 1080p it should consider anything above 720p is 1080p. |
This might be an issue because currently, to anime-dl isn't authenticating properly. So, the token/cookies anime-dl gets aren't authorized for HD and FHD streams. I'll take a look at this, as I am re-building anime-dl. |
Thanks @Xonshiz if you need testing, let me know and I'm glad to help test anything. |
Sure, thanks :). Will hopefully post something in 6 hours from now. |
@Xonshiz |
Still having issues on some older shows with odd resolutions, this time "Full Metal Panic" (https://www.crunchyroll.com/full-metal-panic) which has 1440x1080 as its 1080p resolution.
And this is from "Gunbuster 2" (https://www.crunchyroll.com/gunbuster-2) When I run the command with no resolution called out, it just fails, I need to add "-r 480p" for it to correctly grab the 480p videos
|
See below attachment, two different shows both giving the same result of "DEBUG: video_resolution : x"
The actual downloaded file is also 720p instead of 1080p as my settings indicate.
error.log.txt
The text was updated successfully, but these errors were encountered: