Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable clipboard watermarks #2634

Closed
totaam opened this issue Mar 11, 2020 · 8 comments
Closed

disable clipboard watermarks #2634

totaam opened this issue Mar 11, 2020 · 8 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Mar 11, 2020

Issue migrated from trac ticket # 2634

component: clipboard | priority: minor | resolution: wontfix

2020-03-11 23:26:09: adamhotep created the issue


When I copy an image to or from the clipboard using xpra, it has a one-line timestamp watermark that says:

via Xpra, 2020-03-11T19:09:21.131581

This was my local time (EDT) and was 12 seconds after the screen shot was made, probably referring to when Xpra copied it to my local system.

I would like this to be disabled by default (unless debug is on).


I can't find this with a quick search within the source code, nor can I find any references to this online except perhaps for the Xpra News summary for 3.0 Important Features (2019-09-20), which mentions:\\

Clipboard:

  • HTML5 support for copying images: #2312 (with watermarking)

\I'm using Debian Testing, xpra 3.0.6+dfsg1-1, on both sides.

@totaam
Copy link
Collaborator Author

totaam commented Mar 11, 2020

2020-03-11 23:27:13: adamhotep uploaded file xpra-watermark-bug.png (8.8 KiB)

screenshot of bug
xpra-watermark-bug.png

@totaam
Copy link
Collaborator Author

totaam commented Mar 11, 2020

2020-03-11 23:27:38: adamhotep uploaded file xpra-watermark-bug.zip (65.6 KiB)

xpra bug report output

@totaam
Copy link
Collaborator Author

totaam commented Mar 12, 2020

2020-03-12 03:03:06: antoine changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Mar 12, 2020

2020-03-12 03:03:06: antoine set resolution to wontfix

@totaam
Copy link
Collaborator Author

totaam commented Mar 12, 2020

2020-03-12 03:03:06: antoine commented


To disable the watermark, use:

XPRA_CLIPBOARD_IMAGE_STAMP=0 xpra ...

or

xpra --env=XPRA_CLIPBOARD_IMAGE_STAMP=0 ...

The default will not be changed for now.

@totaam totaam closed this as completed Mar 12, 2020
@totaam
Copy link
Collaborator Author

totaam commented Mar 12, 2020

2020-03-12 03:03:46: antoine changed title from Disable screenshot watermarks to disable clipboard watermarks

@totaam
Copy link
Collaborator Author

totaam commented Mar 12, 2020

2020-03-12 03:03:46: antoine commented


(changing title: this has nothing to do with screenshots)

@totaam
Copy link
Collaborator Author

totaam commented Mar 12, 2020

2020-03-12 15:01:08: adamhotep commented


Ah ha! I hadn't searched for the word "stamp" when I was looking for this.

I'll have to use a wrapper to ensure that variable is set when I invoke xpra.

Perhaps others with this issue who search for "watermark" will find this closed ticket. I recommend updating your documentation too, perhaps at [[Clipboard]].

Thanks for your hard work on this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant