Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DrCCTLib Instruction Analysis Tool #33

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jsalzbergedu
Copy link
Contributor

I have completed a tool that, in a similar format to drcctlib_instr_statistics, analyzes each instruction in each calling context and categorizes the instructions into groups of memory loads, memory stores, branches, jumps, and others.

If there are code quality changes that can be made, please let me know.

Furthermore, I would like to add some tests written in NASM assembler, however, I am aware that this would add NASM as a test dependency. Would that be acceptable?

Thank you.

@dolanzhao dolanzhao requested a review from xl10 September 3, 2020 16:37
@xl10
Copy link
Contributor

xl10 commented Sep 3, 2020

Jacob,

Thanks for your pull request. To have the code merged into the repo, I would like to see your client support (1) multithreaded programs and (2) HPCToolkit format. Are you willing to put some efforts to implement the two features?

@jsalzbergedu
Copy link
Contributor Author

Yes, as soon as I find my next block of free time (probably this weekend) I will implement those two features

jsalzbergedu added a commit to jsalzbergedu/asmexmpl-drcctlib_instr_analysis that referenced this pull request Sep 7, 2020
Allows testing for supporting multithreading, (PR
Xuhpclab/DrCCTProf#33 and issue
jsalzbergedu/DrCCTProf#1 )
Completes 1/2 of the issue
#1 ,
and moves closer to being acceptable for
Xuhpclab#33 .
@jsalzbergedu
Copy link
Contributor Author

Jacob,

Thanks for your pull request. To have the code merged into the repo, I would like to see your client support (1) multithreaded programs and (2) HPCToolkit format. Are you willing to put some efforts to implement the two features?

I know I said I would do it, but I got stuck -- I haven't managed to install hcptoolkit, and I havent figured out how it might be tested for ARM. When you test drcctprof for ARM, what linux distribution (if any) do you test it with?

@xl10
Copy link
Contributor

xl10 commented Jan 11, 2021

Hi Jacob,

We are using the general Ubuntu on ARM. If you are interested in continuing this work, I'm happy to talk to you more and see what we can do in the next step.

Xu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants