Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

redesigned resource store #327

Merged
merged 153 commits into from
Aug 2, 2012
Merged

redesigned resource store #327

merged 153 commits into from
Aug 2, 2012

Conversation

drewfish
Copy link
Contributor

Herein lies the new resource store.

backward-compatibility changes

  • Users will now need to configure the iphone selector by hand ({"settings": ["device:iphone"], "selector":"iphone"}) in their application.json files. (This resource store no longer assumes the selector is just the device.)
  • In a mojit's package.json: the version check is now spelled engines.mojito instead of yahoo.mojito.version.
  • In a mojit's package.json: config.mojito is now spelled yahoo.mojito.
  • The second argument to serializeClientStore() is gone. (This was pretty much internal to mojito anyway, so likely no one will miss it.)
  • The second argument to getAppConfig() is gone. That method now just returns the application configuration (from application.json file).

issues fixed

issues unblocked

This passes yahoo-internal fork build 55, with the exception of one test. That test is broken, and should be updated once this is merged to develop. (The test is using mojito start --context lang=de which is used to set the default context. However, every request gets the lang set in the context, so that will override the default context specified on the command line.)


function readFixtureFile(file){
var path = libpath.join(__dirname, '../../', 'fixtures/ycb' , file);
var data = libfs.readFileSync(path, 'utf8');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jslint

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see other comments about delinting tests...

@mojit0
Copy link
Contributor

mojit0 commented Jul 31, 2012

The GitHub diff didn't allow looking at the store.server.js file :(. But a manual inspection of the file looks solid. All evidence to the contrary from the blizzard of comments above this looks great. And thanks for putting up with my line-by-line review :).

@drewfish drewfish mentioned this pull request Aug 1, 2012
@drewfish
Copy link
Contributor Author

drewfish commented Aug 1, 2012

After all the changes from the code review, I ran another "fork" build. Build 67 passed, except for that single test as mentioned before.

isao pushed a commit that referenced this pull request Aug 2, 2012
@isao isao merged commit a444c1e into YahooArchive:develop Aug 2, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants