This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o mangle as they see fit
|
||
function readFixtureFile(file){ | ||
var path = libpath.join(__dirname, '../../', 'fixtures/ycb' , file); | ||
var data = libfs.readFileSync(path, 'utf8'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jslint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see other comments about delinting tests...
The GitHub diff didn't allow looking at the store.server.js file :(. But a manual inspection of the file looks solid. All evidence to the contrary from the blizzard of comments above this looks great. And thanks for putting up with my line-by-line review :). |
Closed
After all the changes from the code review, I ran another "fork" build. Build 67 passed, except for that single test as mentioned before. |
Conflicts: source/lib/management/utils.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Herein lies the new resource store.
backward-compatibility changes
{"settings": ["device:iphone"], "selector":"iphone"}
) in theirapplication.json
files. (This resource store no longer assumes the selector is just the device.)package.json
: the version check is now spelledengines.mojito
instead ofyahoo.mojito.version
.package.json
:config.mojito
is now spelledyahoo.mojito
.serializeClientStore()
is gone. (This was pretty much internal to mojito anyway, so likely no one will miss it.)getAppConfig()
is gone. That method now just returns the application configuration (fromapplication.json
file).issues fixed
issues unblocked
This passes yahoo-internal fork build 55, with the exception of one test. That test is broken, and should be updated once this is merged to develop. (The test is using
mojito start --context lang=de
which is used to set the default context. However, every request gets the lang set in the context, so that will override the default context specified on the command line.)