Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with PyYAML 6.x? #88

Closed
cdce8p opened this issue Jan 26, 2022 · 2 comments · Fixed by #90
Closed

Compatibility with PyYAML 6.x? #88

cdce8p opened this issue Jan 26, 2022 · 2 comments · Fixed by #90

Comments

@cdce8p
Copy link
Contributor

cdce8p commented Jan 26, 2022

PyYAML is currently pinned with ^5.4.0. Just from looking at the changelog, I would think that version 6.x should also be compatible. Would it be possible to change the requirements to >=5.4.0,<7.0? This would help resolve a dependency conflict for Home Assistant.

https://github.com/yaml/pyyaml/blob/6.0/CHANGES

@FlorianLudwig
Copy link
Member

Hi, thank you for filling a bug report and providing a merge request to fix it :)

Nice!

Love the use-case.

I will merge it - but also opened #94 as we need to ensure that we are actually and stay compatible with the ranges we specify.

@cdce8p
Copy link
Contributor Author

cdce8p commented Jan 30, 2022

Thanks!

I will merge it - but also opened #94 as we need to ensure that we are actually and stay compatible with the ranges we specify.

Not sure if that's all important. With other projects I've worked on, usually only the last version is tested with CI. That works as oftentimes there are only a few actual dependency calls. Thus the min version usually gets checked during refactoring, or bumped if a bug report comes in 😅

I'm not familiar with your codebase though. Just from the example with PyYAML, there is only a single call (excluding the tests) to yaml.load. Probably not worth creating a test matrix for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants