Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to customize bottom bar colors? #520

Open
pablote opened this issue Apr 18, 2019 · 4 comments
Open

How to customize bottom bar colors? #520

pablote opened this issue Apr 18, 2019 · 4 comments

Comments

@pablote
Copy link

pablote commented Apr 18, 2019

Do you want to request a feature or report a bug?
Bug maybe?

What is the current behavior?
Unable to fully customize current bottom bar colors

What is the expected behavior?

I'm trying to change the current purple default for the bottom bar to white, problem is, text is also white so it's not readable. I was able to change some colors using ucrop_color_widget_text and ucrop_color_active_controls_color, but still some parts remain white, see attached screenshot. These are my current settings:

<color name="ucrop_color_widget_background">#ffffffff</color>
    <color name="ucrop_color_widget_text">#FF000000</color>
    <color name="ucrop_color_widget_active">#ffff5722</color>
    <color name="ucrop_color_active_controls_color">#ffff5722</color>

Please attach any image files, URL and stack trace that can be used to reproduce the bug.

Screen Shot 2019-04-18 at 15 26 32

Which versions of uCrop, and which Android API versions are affected by this issue? Did this work in previous versions of uCrop?

com.github.yalantis:ucrop:2.2.3

@saidavdic
Copy link

saidavdic commented Apr 22, 2019

I'm facing the same issue.
This doesn't work properly:
https://github.com/Yalantis/uCrop/blob/master/ucrop/src/main/res/color/ucrop_scale_text_view_selector.xml

< color name="ucrop_color_widget">#xxxxxx</ color> is never used.

@Tsabary
Copy link

Tsabary commented May 9, 2019

Can I ask how were you able to change the default purple? I'm hanging the options programmatic and tried to change all the color options but it is still purple.

    options.setActiveWidgetColor(resources.getColor(R.color.green700))
    options.setStatusBarColor(resources.getColor(R.color.green100))
    options.setActiveControlsWidgetColor(resources.getColor(R.color.white))
    options.setDimmedLayerColor(resources.getColor(R.color.green300))
    options.setToolbarColor(resources.getColor(R.color.green500))
    options.setRootViewBackgroundColor(resources.getColor(R.color.green500))
    options.setToolbarWidgetColor(resources.getColor(R.color.green700))
    options.setCropFrameColor(resources.getColor(R.color.green700))
    options.setCropGridColor(resources.getColor(R.color.green700))
    options.setLogoColor(resources.getColor(R.color.green700))

@saidavdic
Copy link

Try to add this to colors.xml

<color name="ucrop_color_toolbar">#fff</color>
<color name="ucrop_color_statusbar">#f5f5f5</color>
<color name="ucrop_color_toolbar_widget">#000000</color>

<color name="ucrop_color_widget_active">#f5f5f5</color>
<color name="ucrop_color_active_controls_color">#FFFFFF</color>
<color name="ucrop_color_widget_rotate_mid_line">#000000</color>
<color name="ucrop_color_widget_background">#000000</color>

@jesse920524
Copy link

@saidavdic thank you so much, it works!

but I don't think it's a perfact solution.

may be the ucrop would supply API like this:
ucrop#setBottomWidgetBackground(int color)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants