Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress bars and FIt-sne #59

Merged
merged 4 commits into from
Sep 10, 2019
Merged

Add progress bars and FIt-sne #59

merged 4 commits into from
Sep 10, 2019

Conversation

saketkc
Copy link
Contributor

@saketkc saketkc commented Jul 5, 2018

This PR does the following

@duhaime
Copy link
Contributor

duhaime commented Jul 6, 2018

@saketkc Thanks very much for this PR! I love the progress bars, and very much like the idea of the fitsne.

I wanted to ask, though, how do you feel about making the fitsne library an optional dependency? I ask because it has a dependency on header files that are not shipped with the library itself. We could create utils/fitsne-dependencies.txt and list fitsne there, so those who want to kick the tires have an easier time getting started. @pleonard212 and I just discussed the notion of creating a similar utils/gpu-dependencies.txt for those who want to run the processing with GPU-acceleration. We'd just want to update the README to tell users how to use the fitsne layout, and wrap the import statements in utils/process_images.py in a try/catch block.

I also wanted to ask, what is config? You pass it to the tf.Session constructor but it doesn't seem to be defined.

Last, what do you think about adding progress bars for the print statements you commented out? I think those could be nice to have...

@saketkc
Copy link
Contributor Author

saketkc commented Jul 18, 2018

Thanks @duhaime! I have tried to address your comments:

  • Made fitsne optional
  • Added utils/fitsne-dependencies.txt
  • Cleaned up config which was unused from tf.Session

@duhaime
Copy link
Contributor

duhaime commented Sep 10, 2019

Sorry for the insane delay on this @saketkc. I'm just circling back now and this is fantastic! Thanks very much!

@duhaime duhaime merged commit b4fde65 into glevyhas:master Sep 10, 2019
duhaime added a commit that referenced this pull request Sep 24, 2020
Add progress bars and FIt-sne
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants