Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require -d, -l, or -f with csv-timeline and json-timeline #1235

Closed
YamatoSecurity opened this issue Dec 19, 2023 · 2 comments · Fixed by #1241
Closed

require -d, -l, or -f with csv-timeline and json-timeline #1235

YamatoSecurity opened this issue Dec 19, 2023 · 2 comments · Fixed by #1241
Assignees
@hitenkoku
Labels
invalid This doesn't seem right
Milestone
v2.12.0

Comments

@YamatoSecurity
Copy link
Collaborator

When csv-timeline or json-timeline are run, I want to require one of the following options: -d, -l, -f

Right now, if the user runs a command like: ./target/release/hayabusa csv-timeline -o test.csv, hayabusa will still run:


╔╗ ╔╦═══╦╗  ╔╦═══╦══╗╔╗ ╔╦═══╦═══╗
║║ ║║╔═╗║╚╗╔╝║╔═╗║╔╗║║║ ║║╔═╗║╔═╗║
║╚═╝║║ ║╠╗╚╝╔╣║ ║║╚╝╚╣║ ║║╚══╣║ ║║
║╔═╗║╚═╝║╚╗╔╝║╚═╝║╔═╗║║ ║╠══╗║╚═╝║
║║ ║║╔═╗║ ║║ ║╔═╗║╚═╝║╚═╝║╚═╝║╔═╗║
╚╝ ╚╩╝ ╚╝ ╚╝ ╚╝ ╚╩═══╩═══╩═══╩╝ ╚╝
   by Yamato Security

Start time: 2023/12/19 09:11


Elapsed time: 00:00:00.000

@hitenkoku Do you know how to do this?
@YamatoSecurity YamatoSecurity added this to the v2.12.0 milestone Dec 19, 2023
@hitenkoku hitenkoku self-assigned this Dec 19, 2023
@hitenkoku hitenkoku added the invalid This doesn't seem right label Dec 19, 2023
@hitenkoku
Copy link
Collaborator

@YamatoSecurity thanks for your issue.
I will implement.

@YamatoSecurity
Copy link
Collaborator Author

@hitenkoku Thank you!

Sorry, this issue also happens in the other commands as well:

./target/release/hayabusa eid-metrics -o test.csv

╔╗ ╔╦═══╦╗  ╔╦═══╦══╗╔╗ ╔╦═══╦═══╗
║║ ║║╔═╗║╚╗╔╝║╔═╗║╔╗║║║ ║║╔═╗║╔═╗║
║╚═╝║║ ║╠╗╚╝╔╣║ ║║╚╝╚╣║ ║║╚══╣║ ║║
║╔═╗║╚═╝║╚╗╔╝║╚═╝║╔═╗║║ ║╠══╗║╚═╝║
║║ ║║╔═╗║ ║║ ║╔═╗║╚═╝║╚═╝║╚═╝║╔═╗║
╚╝ ╚╩╝ ╚╝ ╚╝ ╚╝ ╚╩═══╩═══╩═══╩╝ ╚╝
   by Yamato Security

Generating Event ID Metrics

Start time: 2023/12/19 09:15


Elapsed time: 00:00:00.000

@hitenkoku hitenkoku changed the title require -d, -l, or -f with csv-timeline and `json-timeline require -d, -l, or -f with csv-timeline and json-timeline Dec 21, 2023
hitenkoku added a commit that referenced this issue Dec 21, 2023
@hitenkoku
fix(configs): added input file option filter to require #1235
119f0a1
hitenkoku added a commit that referenced this issue Dec 21, 2023
@hitenkoku
docs(CHANGELOG): added #1235
282bb2c
@hitenkoku hitenkoku linked a pull request Dec 21, 2023 that will close this issue
added require -d, -l or -f with commands #1241
Merged
@YamatoSecurity YamatoSecurity mentioned this issue Jan 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hitenkoku hitenkoku

Labels
invalid This doesn't seem right
Projects
None yet
Milestone
v2.12.0
Development

Successfully merging a pull request may close this issue.

added require -d, -l or -f with commands Yamato-Security/hayabusa
2 participants
@hitenkoku @YamatoSecurity