Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added require -d, -l or -f with commands #1241

Merged

Conversation

hitenkoku
Copy link
Collaborator

@hitenkoku hitenkoku commented Dec 21, 2023

What Changed

  • Fixed a bug in the csv-timeline, json-timeline, eid-metrics, logon-summary, pivot-keywords-list and search commands so that processing is not executed when the option (-l, -f or -d) specifying the file to be investigated does not exist.

I would appreciate it if you could review when you have time.

@hitenkoku hitenkoku added the invalid This doesn't seem right label Dec 21, 2023
@hitenkoku hitenkoku self-assigned this Dec 21, 2023
@hitenkoku hitenkoku linked an issue Dec 21, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3d71dae) 82.45% compared to head (e79d45f) 82.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1241   +/-   ##
=======================================
  Coverage   82.45%   82.45%           
=======================================
  Files          27       27           
  Lines       24714    24714           
=======================================
  Hits        20377    20377           
  Misses       4337     4337           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hitenkoku
Copy link
Collaborator Author

Evidence

  • csv-timeline
> ./1235.exe csv-timeline -o out.csv -C
error: the following required arguments were not provided:
  <--directory <DIR>|--file <FILE>|--live-analysis>

Usage: 1235.exe csv-timeline --output <FILE> --clobber <--directory <DIR>|--file <FILE>|--live-analysis>
  • json-timeline
> ./1235.exe json-timeline -o out.json -C
error: the following required arguments were not provided:
  <--directory <DIR>|--file <FILE>|--live-analysis>

Usage: 1235.exe json-timeline --output <FILE> --clobber <--directory <DIR>|--file <FILE>|--live-analysis>
  • eid-metrics
> ./1235.exe eid-metrics -o out.csv -C  
error: the following required arguments were not provided:
  <--directory <DIR>|--file <FILE>|--live-analysis>

Usage: 1235.exe eid-metrics --output <FILE> --clobber <--directory <DIR>|--file <FILE>|--live-analysis>
  • logon-summary
> ./1235.exe logon-summary -o out.csv -C
error: the following required arguments were not provided:
  <--directory <DIR>|--file <FILE>|--live-analysis>

Usage: 1235.exe logon-summary --output <FILENAME-PREFIX> --clobber <--directory <DIR>|--file <FILE>|--live-analysis>
  • pivot-keywords-list
> ./1235.exe pivot-keywords-list -o out -C
error: the following required arguments were not provided:
  <--directory <DIR>|--file <FILE>|--live-analysis>

Usage: 1235.exe pivot-keywords-list --output <FILENAME-PREFIX> --clobber <--directory <DIR>|--file <FILE>|--live-analysis>
  • search
> ./1235.exe search -o out.csv -k mimikatz -C
error: the following required arguments were not provided:
  <--directory <DIR>|--file <FILE>|--live-analysis>

Usage: 1235.exe search --output <FILE> --keyword <KEYWORD...> --clobber <--directory <DIR>|--file <FILE>|--live-analysis>

@hitenkoku hitenkoku changed the title added require d l or f with commands added require -d, -l or -f with commands Dec 21, 2023
Copy link
Collaborator

@fukusuket fukusuket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that Integration-Test is also successful. LGTM!!🚀
https://github.com/Yamato-Security/hayabusa/actions/runs/7283701111

Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hitenkoku LGTM! Thank you so much!

@YamatoSecurity YamatoSecurity merged commit cf130e5 into main Dec 21, 2023
7 checks passed
@hitenkoku hitenkoku deleted the 1235-require-d-l-or-f-with-csv-timeline-and-json-timeline branch January 11, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

require -d, -l, or -f with csv-timeline and json-timeline
3 participants