Upstream #2
Open
Upstream #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarifying usage in conjunction with use_group_vars
* Fix loading legacy vars plugins when the plugin loader cache is reset * Remove extra cache layer by ensuring vars plugin names are cached (stateless or not) so that the plugin loader cache can double as the load order
Jinja may generate an invalid Python source code from a template. Trying to compile such source code into a Python code object results in SyntaxError being thrown. An example of such a template is providing the same keyword argument into a lookup twice, resulting in: `SyntaxError: keyword argument repeated`. Since `jinja2.exceptions.TemplateSyntaxError` does not cover such a case, as it is not a Jinja parsing error, we need to catch SyntaxError explicitly ourselves. Fixes #82606
* prettify ansibile-doc output delimiters when no color avoid triggering color mode for existing tests all use _format to observe nocolor more v more info imporoved conditional display updated version on -v normalize role errors expand role data, dedupe code, fix formatting on warning fix bug with galaxy info role list improvements: lists all roles (even w/o meta/argspec) specs now indented under role role only listed once Updated tests to reflect format changes Co-authored-by: Felix Fontein <felix@fontein.de>
Fixes: #78703 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* Allow for arbitrary key 'context' in argument spec
best/nobest options are one of the options whose default values are set by an OS distribution. For example in our CI, both Fedora and RHEL set the best option to different default values. As such we should defer to the distributions for the default value and not change it by default but if users wish to change it they can do so explicitly. Currently the dnf module sets the nobest option inconsistenly and not for all cases. This patch fixes that to reflect the behavior described above. In addition adding the best option for both dnf and dnf5 modules since the best option is prefer to nobest in dnf while in dnf5 nobest is completely removed in favor of best. Fixes #82616
* 'src,src', 'dst,dst' added as new option choices in match_set_flags option Fixes: #81281 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* Allow subdirectories with import_role _from options
Add tests that tasks_from is restricted to the role
Note that a task like:
- import_role:
name: role
tasks_from: tasks/entrypoint.yml
will now load tasks from "{{ role_path }}/tasks/tasks/entrypoint.yml"
instead of "{{ role_path }}/tasks/entrypoint.yml". This change in
behavior matches include_role.
* better test case (filename doesn't match one in tasks/)
Fixes #82584
Fixes: #82463 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
The ``validate-modules`` sanity test no longer attempts to process files with unrecognized extensions as Python. Integration tests have been added to verify Python-specific checks do not apply to these files. The `invalid-extension` and `missing-gplv3-license` checks still apply to these files. This may change in the future.
* original test assertion was not quoted properly and was thus silently "truthy" instead of actually functioning
Co-authored-by: Matt Davis <6775756+nitzmahone@users.noreply.github.com>
Changed successfull to successful
allow extra vars when templating j2 files in the skeleton, for example: ansible-galaxy init --role-skeleton /path/to/skeleton --extra-vars @/path/to/vars_file.yml newrole ansible-galaxy init --extra-vars "min_ansible_version=2.17.0" newrole
Additionally, this patch takes care of installing GPG within the `ansible-galaxy-collection` test when running under macOS 14 and higher. PR #82697 ci_complete
* ansible-test - Add work-around for pytest>=8 errors * Update changelogs/fragments/ansible-test-pytest-8.yml Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
* fix: ensure path argument doesn't have a backslash * feat: add changelog * Update lib/ansible/cli/__init__.py Co-authored-by: Matt Clay <matt@mystile.com> * Simplify logic and add tests --------- Co-authored-by: dorkamotorka <teo.podobnik1234@gmail.com> Co-authored-by: Teodor Janez Podobnik <48418580+dorkamotorka@users.noreply.github.com> Co-authored-by: Matt Clay <matt@mystile.com>
Co-authored-by: Taiki Fujiwara <taiki.fujiwara@miraclelinux>
Fixes: #81628 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* ansible-test - Update tested platforms * Add work-around for Alpine tests * Fix prepare_http_tests on Fedora * Fix deb-src setup for Ubuntu 24.04+ * Set multiarch_test_pkg for Ubuntu 24.04 * Update AZP test matrix
Splitting on all '=' characters produced too many values.
Fixes: #83390 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
The dnf-nightly is the official nightly repo now.
Previously, if the checksum of the downloaded file did not match the specified checksum, the *destination* file was removed. This possibly leaves the system that is being provisioned in an invalid state. Instead, the checksum should be calculated on the temporary file only. If there's a mismatch, delete the *temporary* file, not the destination file. This requires checking the checksum before moving the file.
Consider content differs and size differs while unarchiving the same tar.gz file Fixes: #29610 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
we only templated in some cases but when queueing we could get an untemplated name for the 'on start' event.
* Enable Ubuntu 24.04 group 6 in CI * Disable rootfull Podman on Ubuntu * Disable unix-chkpwd AppArmor profile on Ubuntu for Fedora 40 tests * Document AppArmor and rootfull issues
Identical branches in conditional node: 'elif name != permanent_hostname' and 'else'. First bruch is not nessesary Co-authored-by: mar.s <marchenkov.s.d@gmail.com>
Previously, `support_discard` simply returned the value of
`/sys/block/{device}/queue/discard_granularity`. When its value is `0`, then
the block device doesn't support discards; _however_, it being greater than
zero doesn't necessarily mean that the block device _does_ support discards.
But another indication that a block device doesn't support discards is
`/sys/block/{device}/queue/discard_max_hw_bytes` being equal to `0` (with the
same caveat as above). So if either of those are `0`, set `support_discard` to
zero, otherwise set it to the value of `discard_granularity` for backwards
compatibility.
Signed-off-by: Benoît Knecht <bknecht@protonmail.ch>
Fixes #83498 Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
…83500) * Replace references to archived ansible/ansible-examples repository * Update examples to reference ansible repository * Include HTTPS among SSH references in examples
previouslly we recorded but did not show to avoid spam
since we could not dedup from forks, that was already
fixed in another PR so now we can show/display them.
Also:
* funcitonalize deprecation msg construct from docs
* reuse formatting func in cli
* normalize alternatives: most of the code used intended plural
but some and most data/tests used the singular
* update schemas and tests
Co-authored-by: Matt Davis <6775756+nitzmahone@users.noreply.github.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
fixes #82872 nicer implementation courtesy of nitzmahone
* package_facts: fix warning logic * Refactor so that warnings can work
…ing to different options (#83530) * Reject option/alias names equal up to casing belonging to different options. * Update test/lib/ansible_test/_util/controller/sanity/validate-modules/validate_modules/main.py Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION