Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make model names generic #5

Closed
flukejones opened this issue Aug 1, 2021 · 1 comment
Closed

Make model names generic #5

flukejones opened this issue Aug 1, 2021 · 1 comment

Comments

@flukejones
Copy link

flukejones commented Aug 1, 2021

We have pretty concrete information form the last... lots of months that these naming schemes can be reduced down to GA401I, GA401Q which would enable much easier support of model variants instead of trying to catch and match them all.

match name {
"GA401IV" => Some(Board::Ga401),
"GA401IU" => Some(Board::Ga401),
"GA401II" => Some(Board::Ga401),
"GA401IVC" => Some(Board::Ga401),
"GA401IH" => Some(Board::Ga401),
"GA401QM" => Some(Board::Ga401),
_ => None,

@Yarn
Copy link
Owner

Yarn commented Aug 11, 2021

d3334c8

released, version 0.1.10

@Yarn Yarn closed this as completed Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants