Skip to content
This repository has been archived by the owner on Aug 30, 2018. It is now read-only.

New HTML5 Player design broke resizing #1612

Closed
ldeichmann opened this issue Apr 2, 2015 · 24 comments
Closed

New HTML5 Player design broke resizing #1612

ldeichmann opened this issue Apr 2, 2015 · 24 comments
Labels

Comments

@ldeichmann
Copy link

Hey,
I just got hit with a new HTML5 Player Design which broke resizing. Using Build 497 on Chromium 41.0.2272.118
screenshot from 2015-04-02 13 24 25
In fullscreen, the changes are more evident
screenshot from 2015-04-02 13 24 40

@Yonezpt
Copy link
Collaborator

Yonezpt commented Apr 3, 2015

Haven't yet received the transparent player. Can you open your console, enter this:

ytplayer.config.assets.js

And share with me the link it shows? I want to try forcing the script on my side to see if I can get it to cooperate.

@YePpHa YePpHa added the bug label Apr 3, 2015
@Vashetti
Copy link

Vashetti commented Apr 3, 2015

Can confirm this is also occurring on Safari on the latest dev version. Feels like I've had this bug for over a year now. I just want videos to fill the actual player size...

@Yonezpt
Copy link
Collaborator

Yonezpt commented Apr 3, 2015

@Vashetti Are you also getting the transparent player like the original poster? If so can you do what I asked in my reply above so that we can study the code and try to find a solution?

@0xBRM
Copy link

0xBRM commented Apr 3, 2015

Happening on FF dev build.

@Yonezpt
Copy link
Collaborator

Yonezpt commented Apr 3, 2015

@CrisBRM Can you do what I asked in my replies above? Otherwise it will be impossible to find a solution if we do not have access to the same player that you guys are receiving.

@0xBRM
Copy link

0xBRM commented Apr 3, 2015

"//s.ytimg.com/yts/jsbin/html5player-en_GB-vflii3He3/html5player.js"

This video: https://www.youtube.com/watch?v=I2qBBBvYQOA

@Vashetti
Copy link

Vashetti commented Apr 3, 2015

@Yonezpt I don't have the transparent player, no.

@Yonezpt
Copy link
Collaborator

Yonezpt commented Apr 3, 2015

@Vashetti Then your issue is different than this one, you should create a new issue because this one is specific to the new YouTube transparent player.

@Vashetti
Copy link

Vashetti commented Apr 3, 2015

@Yonezpt My issue has had several threads on it in the past. Safari videos rarely fill the screen, people say download the dev version, but it never seems to fix the specific Safari issues, despite people saying the video size filling issue is fixed on Chrome, Firefox, etc.

@Yonezpt
Copy link
Collaborator

Yonezpt commented Apr 3, 2015

@Vashetti Then it's a matter of waiting until the addon author has the time to address the issue. It has been reposted recently in #1606

@Yonezpt
Copy link
Collaborator

Yonezpt commented Apr 3, 2015

Alright, after fiddling around with the script shared by @CrisBRM I can conclude that the resizing fix that I created is still working correctly. I replaced the YouTube player script I am receiving with the one shared by Cris and the video resizes as normal, so the issue lies somewhere else.

@CrisBRM Does your YouTube player also have transparent controls like the one shown in the screenshots posted by pezam?

@0xBRM
Copy link

0xBRM commented Apr 3, 2015

@Yonezpt No, it's the normal YT player.

@Yonezpt
Copy link
Collaborator

Yonezpt commented Apr 3, 2015

@CrisBRM Then your problem is also not the same issue as the one reported by the OP, but most likely the same as @Vashetti

@ldeichmann
Copy link
Author

Hey, sorry, my cookies get deleted every time my browser exits, so I don't have that player anymore. Hopefully someone else can get you that info, I'm sure they'll roll it out further soon.

@Yonezpt
Copy link
Collaborator

Yonezpt commented Apr 3, 2015

@PezaM So am I correct in assuming that the issue is no longer present now that you have the normal player?

@Uoipka
Copy link

Uoipka commented Apr 3, 2015

Because of this problem did not use HTML5 long time. On FLASH all works well
Use Opera 29.0.1795.30

@Yonezpt
Copy link
Collaborator

Yonezpt commented Apr 4, 2015

@Uoipka Unless your player also has transparent controls like the one displayed in the OP's screenshot, then your problem is not related to this one and has already been reported. Also make sure that you are using the latest dev version 497 which can be downloaded from here: https://github.com/YePpHa/YouTubeCenter/wiki/Developer-Version

@0xBRM
Copy link

0xBRM commented Apr 4, 2015

@Yonezpt You're right, it works now.
Thanks!

@Uoipka
Copy link

Uoipka commented Apr 4, 2015

@Yonezpt, well dev version fix problem "broke resizing" but i can watch only 360/720p quality now seems like new problem

@0xBRM
Copy link

0xBRM commented Apr 4, 2015

@Uoipka Are you sure it's still forcing Flash? Can you try with both player types?

@Uoipka
Copy link

Uoipka commented Apr 4, 2015

@CrisBRM flash have all 360,480 etc... HTML5 have only 360,720HD

@Yonezpt
Copy link
Collaborator

Yonezpt commented Apr 4, 2015

@Uoipka Check that you don't have DASH disabled in YTC options. I don't know Opera's HTML5 capabilities, but if they are like firefox 36 and below then you will only get 240p/360p and 720p when using the HTML5 player. See #1197 and #1080

@Uoipka
Copy link

Uoipka commented Apr 4, 2015

@Yonezpt oh, it's problem from opera. i try same and waiting for opera developers... he have MSE & H.264 support at opera://flags/ but it buggy.

@ldeichmann
Copy link
Author

@Yonezpt Yes, I suppose for the time being it can be closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants