Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes VC libraries are not copied #30

Closed
innim98 opened this issue Mar 14, 2021 · 4 comments
Closed

Sometimes VC libraries are not copied #30

innim98 opened this issue Mar 14, 2021 · 4 comments
Labels
bug Something isn't working fixed bug fixed

Comments

@innim98
Copy link

innim98 commented Mar 14, 2021

_vCLibsFiles.forEach((file) async => await File(file.path)

Hi, it's first time to raise an issue on here.
I realized sometimes vcruntime140.dll and vcruntime140_1.dll is missing when I build MSIX package.
It looks like it starts "packing.." before it finishes copyVCLibsFiles()
I guess it's from the delay in async-foreach process.
ref: https://stackoverflow.com/questions/42467663/async-await-in-list-foreach
Could you check the parts, please?

@YehudaKremer YehudaKremer added the bug Something isn't working label Mar 14, 2021
@YehudaKremer
Copy link
Owner

YehudaKremer commented Mar 14, 2021

Hello @innim98
thank you for this bug report

i switch to use normal for loop to resolve this bug: commit
this fix include in version 0.1.17

@YehudaKremer YehudaKremer added the fixed bug fixed label Mar 14, 2021
@innim98
Copy link
Author

innim98 commented Mar 14, 2021

Hello @YehudaKremer Thank you for quick update!
I realized there is one more point.
listen
Sometimes, the callback for listen() method works later than processing VC libraries. As of result, vcruntime140_1.dll is missed. (1 out of 3 times in my environment)
Could you change it as well? Thank you.

@YehudaKremer
Copy link
Owner

Done:) now the files actions are Sync.
fix include in version 0.1.18: commit

@innim98 thank you for this important report,
please check if now all the files are copied properly

@innim98
Copy link
Author

innim98 commented Mar 14, 2021

@YehudaKremer Thank you for the great job.
The files are packed normally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed bug fixed
Projects
None yet
Development

No branches or pull requests

2 participants