Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Remove next_point argument from GradientDescentOptimization() #186

Closed
suntzu86 opened this issue Jun 7, 2014 · 0 comments · Fixed by #348
Closed

[C++] Remove next_point argument from GradientDescentOptimization() #186

suntzu86 opened this issue Jun 7, 2014 · 0 comments · Fixed by #348

Comments

@suntzu86
Copy link
Contributor

suntzu86 commented Jun 7, 2014

At some previous point, I intended to make it so that callers communicate with optimizers by doing:

  • objective_state.SetCurrentPoint() to set the initial guess (pre-call)
  • objective_state.GetCurrentPoint() to fetch the solution (post-call)

Somehow I missed GradientDescentOptimization in gpp_optimization.hpp. Let's remove this superfluous argument and update the code & the call-sites accordingly.

NewtonOptimization (same file) is an example of a function where this has been done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants