You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
EvaluateLogLikelihoodAtPointList and LatinHypercubeSearchHyperparameterOptimization in gpp_model_selection_and_hyperparameter_optimization.hpp do not pass back a "found_flag" term, unlike every other optimizer/evaluation function in optimal_learning.
For consistency, we should change this.
EvaluateLogLikelihoodAtPointList should have a found_flag output that is read from io_container right before return.
LatinHypercubeSearchHyperparameterOptimization should have a found_flag output that is passed straight to EvaluateLogLikelihoodAtPointList
InitializeBestKnownPoint should have check_all_points dropped and it should ONLY be called from places that don't invoke the NullOptimizer.
EvaluateLogLikelihoodAtPointList should stop calling InitializeBestKnownPoint. Instead, build io_container with the first multistart point (arbitrary) and set its value to -std::numeric_limits<double>::max() (or -infinity()?)
The text was updated successfully, but these errors were encountered:
EvaluateLogLikelihoodAtPointList
andLatinHypercubeSearchHyperparameterOptimization
ingpp_model_selection_and_hyperparameter_optimization.hpp
do not pass back a "found_flag" term, unlike every other optimizer/evaluation function in optimal_learning.For consistency, we should change this.
EvaluateLogLikelihoodAtPointList
should have a found_flag output that is read fromio_container
right before return.LatinHypercubeSearchHyperparameterOptimization
should have afound_flag
output that is passed straight toEvaluateLogLikelihoodAtPointList
InitializeBestKnownPoint
should havecheck_all_points
dropped and it should ONLY be called from places that don't invoke the NullOptimizer.EvaluateLogLikelihoodAtPointList
should stop callingInitializeBestKnownPoint
. Instead, buildio_container
with the first multistart point (arbitrary) and set its value to-std::numeric_limits<double>::max()
(or-infinity()
?)The text was updated successfully, but these errors were encountered: