Fix AttributeError if required array param is not supplied #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
Looks good! Nice to see the handle_null_value get put to immediate use. |
macisamuele
added a commit
to macisamuele/bravado-core
that referenced
this pull request
Jan 11, 2019
…er_spec_validator Yelp#111)
macisamuele
added a commit
to macisamuele/bravado-core
that referenced
this pull request
Jan 11, 2019
…er_spec_validator Yelp#111)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've observed AttributeErrors internally if a required parameter of type array is not passed, instead of the expected schema or validation exception. This is because validation happens after unmarshalling of the array, and a missing required parameter is not currently handled correctly during unmarshalling.