Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix equivalence check in deref_flattened_spec_test.py #357

Merged
merged 2 commits into from
Nov 4, 2019
Merged

Fix equivalence check in deref_flattened_spec_test.py #357

merged 2 commits into from
Nov 4, 2019

Conversation

nickgaya
Copy link
Contributor

Fixes a nondeterministic unit test failure caused by a buggy test helper function.

@coveralls
Copy link

coveralls commented Oct 31, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 99.006% when pulling bb01208 on nickgaya:fix-deref-flattened-spec-test into e5152e2 on Yelp:master.

sjaensch
sjaensch approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@sjaensch sjaensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @nickgaya !

@sjaensch sjaensch merged commit 265d63f into Yelp:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjaensch sjaensch sjaensch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickgaya @coveralls @sjaensch