-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop gracefully on SIGTERM #21
Comments
@drolando: nice find 🥇 That explains why we're seeing spurious 503 spikes. |
So far I haven't able to solve this problem, but here's a repro:
Expected:The request to Actual:Connection is aborted and we get "curl: (52) Empty reply from server", docker shuts down at the same time Some things that might be useful to note here
|
We can use dumb-init to change the SIGTERM in a SIGQUIT
|
Nice. Just verified, it totally works ( |
When an instance fails the healthcheck, paasta sends a SIGTERM, waits a bit and then kills the process if it hasn't stopped yet.
Right now we don't catch SIGTERM, so the process dies as soon as it receives it. All in-flight requests are lost and clients see this as a 503.
The text was updated successfully, but these errors were encountered: